[GLUTEN-8018][CORE] Support adjusting stage resource profile dynamically #8209
+198
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
|
Thank you for splitting the PR into 2. Let's discuss in #8195 before moving forward to this one. |
PHILO-HE
changed the title
PHILO-HE
changed the title
zjuwangg
force-pushed
the
m_stageRP_2
branch
from
8073c47 to
7786636
Compare
|
Run Gluten Clickhouse CI on x86 |
| @@ -109,6 +109,7 @@ object VeloxRuleApi { | |||
| injector.injectFinal(c => RemoveGlutenTableCacheColumnarToRow(c.session)) | |||
| injector.injectFinal(c => GlutenFallbackReporter(c.glutenConf, c.session)) | |||
| injector.injectFinal(_ => RemoveFallbackTagRule()) | |||
| injector.injectFinal(c => GlutenAutoAdjustStageResourceProfile(c.glutenConf, c.session)) | |||
There was a problem hiding this comment.
Can we move the rule between RemoveGlutenTableCacheColumnarToRow and GlutenFallbackReporter? Thanks.
| @@ -180,5 +181,6 @@ object VeloxRuleApi { | |||
| injector.injectPostTransform(c => RemoveGlutenTableCacheColumnarToRow(c.session)) | |||
| injector.injectPostTransform(c => GlutenFallbackReporter(c.glutenConf, c.session)) | |||
| injector.injectPostTransform(_ => RemoveFallbackTagRule()) | |||
| injector.injectPostTransform(c => GlutenAutoAdjustStageResourceProfile(c.glutenConf, c.session)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's a follow PR of #8195 and demonstrate how to adjust resource profile through Rule.
How was this patch tested?
Unit test will be updated soon.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)